Refactor Value::Array and add Value::Enum #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Still need to work on SeaORM to tweak the Enum design. |
This was referenced Nov 4, 2025
tyt2y3
added a commit
that referenced
this pull request
Nov 8, 2025
## PR Info - Closes #69 ## New Features - [ ] Provide a new type `RangeType` to implement Postgres range type - [ ] Provide range type as an element type of Postgres Array ## Doubts - [ ] Not sure where to implement `hashable-value` features. I put that in the `with_range.rs` - [ ] It implements time ranges with Chrono and Time I left out Jiff now - [ ] Not sure how it plays together with `with-json` - [ ] How to make RangeType from std Rust types (tuple, std range, how to describe exclusive and inclusive bounds?) - [ ] A refactor PR is going on which may affect this branch (#1004) --------- Co-authored-by: Chris Tsang <[email protected]>
tyt2y3
approved these changes
Dec 4, 2025
Member
tyt2y3
left a comment
tyt2y3
left a comment
There was a problem hiding this comment.
thank you. this is longer than I can dissect in one go, but looks good in general
tyt2y3
reviewed
Dec 6, 2025
| } | ||
|
|
||
| // If bigdecimal is enabled and its size is larger, we make the limit to be bigdecimal's size | ||
| #[cfg(feature = "with-bigdecimal")] |
Member
There was a problem hiding this comment.
we need to disable bigdecimal by default in sea-orm
Huliiiiii
force-pushed
the
value-array
branch
2 times, most recently
from
e05f1c9 to
1fffd2a
Compare
Member
must be a problem with feature flags? |
Huliiiiii
force-pushed
the
value-array
branch
from
1fffd2a to
0bcd031
Compare
Huliiiiii
force-pushed
the
value-array
branch
from
0bcd031 to
69180f5
Compare
Member
Author
|
@Expurple Which do you prefer? Arrry::Type(Option(...)) or Array::Null(ArrayType) |
Member
|
I'd say |
tyt2y3
approved these changes
Dec 17, 2025
tyt2y3
reviewed
Dec 19, 2025
| #[derive(Debug, Clone)] | ||
| #[cfg_attr(not(feature = "hashable-value"), derive(PartialEq))] | ||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| #[non_exhaustive] |
Member
There was a problem hiding this comment.
this doesn't have to be non_exhaustive I guess?
Member
Author
There was a problem hiding this comment.
Value is non_exhaustive, so this should also be non_exhaustive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ARRAY[instead ofARRAY [to match SQL conventions